On Thu, Aug 10, 2017 at 5:25 PM, Christopher Li <sparse@xxxxxxxxxxx> wrote: > On Thu, Mar 16, 2017 at 4:43 PM, Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote: > > Sorry for not able to join the discussion earlier. I am catching up > my backlogs of discussion. I have think about this for a while now. > I think there is one alternative solution is just give set_val instruction > a size (not type). > > reason being: > 1) Necessary for CSE as well. > If CSE combine two set_val of different size as one pesudo. > and it is used as two different size. That is likely a bug. Absolutely not. Anyway, currectlyeach distinct value correspond to a *single/unique* pseudo. IN other words, there is no need to do any kind of CSE on *values*, they are already kinda pre-CSEed at their creation (because a constant value is nothing more than this value). Sorry, this has been tried and discussed already. It doesn't really work. * a size is essentially a type, certainly for integers in sparse IR. * A constant is a constant, 1 is 1, when it has 1 bit or 64 bits, it's the same constant and follow the same mathematical rules. It's even not signed or unsigned, it's just 1. * in sparse, types are conveyed by the *operations* made on their operands. There are lots of good reasons for this. Trying to do the opposite for these constants will just break a lot of things, duplicate a lot of code (try it) and bring confusion everywhere (because of simply using the operation you then need at each time check the type of the operands. It's something we want to avoid (like for the discussion about casts we had yesterday) not something we want to add). * the OP_PUSH instructions do a perfect job of giving a type to functions arguments * the OP_PUSH instructions also nicely abstract away the *operation* of argument passing that all architectures have. It's a good thing. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
