On Thu, Jul 20, 2017 at 12:57 PM, Christopher Li <sparse@xxxxxxxxxxx> wrote: > On Thu, Jul 6, 2017 at 3:19 PM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: >> + sym = expr->symbol; >> + if (sym->bb_target) >> + buf += sprintf(buf, ".L%u", sym->bb_target->nr); > You chould do: > bb = expr->symbol->target; > if (bb) > buf += sprintf(buf, ".L%u", bb ? bb->nr); > else > buf += sprintf(buf, ".L<invalid>"); > > It is up to you. Yes, it's more informative but I have a later series which convert all these to calls to a function show_label() which then do the right thing. So, I prefer to leave like this for the moment. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html