Apologies for the typo - correction below. On 7 July 2017 at 10:19, Dibyendu Majumdar <mobile@xxxxxxxxxxxxxxx> wrote: > Hi, > > On 7 July 2017 at 07:02, Christopher Li <sparse@xxxxxxxxxxx> wrote: >> On Thu, Jul 6, 2017 at 10:44 PM, Luc Van Oostenryck >> <luc.vanoostenryck@xxxxxxxxx> wrote: >>> The ptrlist is already fragile and now it would contains >>> yet another field that need to be taken care of *and* stay >>> coherent with other users. I doubt this will help to reduce bugs. >>> >> The reason ptrlist is fragile >> is we did not do it properly. Not safe against recursive ptr >> loop with inner loop delete stuff from the same list. >> > In general though - while a list is being traversed, deleting items should be expected to work, as long as a ptrlist node is not deleted. The reason is that an iterator is presumably on a particular node - and if unknown to if the node it is on is deleted, then the iterator has no way to continue. So maybe calling pack in the middle of an operation is causing the problem? I think the current implementation (and my version too) is safe as long as nodes are not deleted while a traversal is going on? Thanks and Regards Dibyendu -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
