On Thu, Jul 06, 2017 at 06:18:48PM -0700, Christopher Li wrote: > On Thu, Jul 6, 2017 at 5:40 PM, Christopher Li <sparse@xxxxxxxxxxx> wrote: > Most noticablely remove_usage() inside of the kill_use_list() > loop. Can you explain a bit what's wrong with this one? The call chain looks basically like: simplify_instruction() loop over ep->bb & bb->insns) kill_use_list() loop over insn->phi_list kill_use() -> remove_use() delete_pseudo_user_list_entry loop over pseudo->users kill_instruction() kill_use_list() Note: kill_instruction() doesn't delete the instruction from the BB but just mark them as removed which is, I think, the right pattern to adopt in general instead of the delete/pack. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html