On Tue, Jun 20, 2017 at 09:07:40PM +0200, Luc Van Oostenryck wrote:
> On Tue, Jun 20, 2017 at 06:04:01PM +0100, Will Deacon wrote:
> > On Tue, Jun 20, 2017 at 06:24:32PM +0200, Luc Van Oostenryck wrote:
> > > On Tue, Jun 20, 2017 at 04:49:39PM +0100, Will Deacon wrote:
> > > > Looks fine to me, but just wondering whether or not we should also be
> > > > passing something to indicate the endianness of the target. Does sparse care
> > > > about that?
> > >
> > > Yes, we should. sparse doesn't care per-se but some macros, structures
> > > or whole portion of code may depends on '__{LITTLE,BIG}_ENDIAN__'
> > > being defined or not, for example (but I don't think it will make
> > > a big difference, at least nothing like the 629904 'constant is so big'
> > > warnings we have now due to the missing -m64).
> > >
> > > For this, you have two possibilities:
> > > 1) just doing something like PPC:
> > > +ifdef CONFIG_CPU_BIG_ENDIAN
> > > +CHECKFLAGS += -D__BIG_ENDIAN__
> > > +else
> > > +CHECKFLAGS += -D__LITTLE_ENDIAN__
> > > +endif
> > > This will work now. I can't send you a proper patch if you wish.
> > >
> > > 2) a cleaner solution, IMO, would be to teach sparse about
> > > -mlittle-endian/-mbig-endian. In fact I already wrote the patch
> > > earlier today. But of course, you will need to wait for the patch
> > > to reach sparse's master and then compile sparse yourself or wait
> > > for a new release (which shouldn't take much long, though).
> >
> > If you do that, you could also teach it that AArch64 is 64-bit ;)
>
> Well, currently sparse is arch agnostic and I think it's a good thing.
> For the few arch specifities you have to use some of the '-m' flags
> (like -m32/-m64, -msize-long). So, for the moment the '-m64' flag
> is needed, thus the patch.
Ok, I'll pick your patch up then. The endianness case is more interesting,
because I don't think __BIG_ENDIAN__ and __LITTLE_ENDIAN__ are the defines
to use; the kernel seems to omit the trailing underscores afaict.
Will
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
