On Fri, Jun 16, 2017 at 10:08:18AM -0700, Christopher Li wrote: > On Thu, Jun 15, 2017 at 1:20 AM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > > Please, drop what you have already pulled and take the > > following instead. > > I am reviewing the pull request, here is some of the feed back for the memcpy > patch. Mmmm. 10 days ago you said for this series: "This V2 version of the series looks perfectly fine to me." > For -fmemcpy-max-count and -Wmemcpy-max-count, do we actually need to > have two separate options here? -fmemcpy-max-count set to zero will disable > this warning any way. We don't need to, but what does it cost us to have both? What it would bring us if we don't? I'm seeking coherence, here. In sparse, like in gcc or clang, warnings are enabled and disabled with '-WXXX' and '-Wno-XXX' options. The other flag is used to tune some settings. It's all pretty simple and without surprises. And using '0' as special value meaning 'unlimited' is pretty common too. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
