Re: [PATCH] fix: kill unreachable BBs after killing a child

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 9, 2017 at 8:27 AM, Luc Van Oostenryck
<luc.vanoostenryck@xxxxxxxxx> wrote:
> Like a lot of things, it depends.
> For example, the kernel use a lot inline functions or macro with
> code like:
>         ...
>         switch (sizeof(x)) {
>         case 1: ...
>         case 2: ...
>         case 4: ...
>         case 8: ...
>         default: issue a build error
>         }

Ha, that is good to know.

> Also, the simplification concerned here is 'insert_branch()'
> which, like I explained in the commit message, is used by the
> switch simplification but is also used by other branch
> simplifications.
>
>> Have two switch
>> statement in same function get simplify at the same time should be
>> even rarer.
>> Might not worth the effort to optimize for that.
>>
>> As it is, the patch is acceptable.
>
> I really also would prefer that we would not have to walk the BBs
> but I really think we don't have good others choices.

Yes, that is what I am afraid as well, it might not worth the complexity
try to optimist for it.

I have not problem walk the BBs, I just don't want to walk it more than
once if easy avoidable. Looks like there is no easy way to get it.

Let's leave it as it is.  You convinced me.  ACK.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux