On Sat, Apr 1, 2017 at 1:27 AM, Christopher Li <sparse@xxxxxxxxxxx> wrote:
>> + curr->generation = generation;
>> + FOR_EACH_PTR(curr->children, bb) {
>> + if (bb->generation == generation)
>> + continue;
>> + if (bb == phi->bb)
>> + continue;
>> + if (pseudo_in_list(bb->defines, target)) {
>> + continue;
>> + }
>
> For just one line continue, there is no need for {}
>
>> + if (pseudo_in_list(bb->needs, target)) {
>> + rc = 1;
>> + goto ret;
>
> Can this simplify as "return 1;"
>
>> + }
>> + rc = needed_phisrc(phi, bb, generation);
>> + if (rc)
>> + goto ret;
> needed_phisrc(phi, bb, generation)
>
> And "return 1;" here
>> +
>> + } END_FOR_EACH_PTR(bb);
>
>
>> +
>> +ret:
>> + return rc;
>
> "return 0" here.
> There is no need for rc variable.
Yes, sure. This is some debugging leftover.
In truth, I detest this patch, it's a bandaid more than anything else
but I haven't anything better for the moment.
I'll respin it but it will most probably be for Sunday.
-- Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
