Re: extra 'make check' failures on 32bit Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 27, 2017 at 5:27 PM, Ramsay Jones
<ramsay@xxxxxxxxxxxxxxxxxxxx> wrote:

> So, I looked in the debugger and 'bits_in_long' and 'bits_in_pointer'
> are set correctly, but __LONG_MAX__ is being printed with an LL suffix,
> so, this fixes it for me:
>
> $ git diff
> diff --git a/lib.c b/lib.c
> index 272d2c8..502c264 100644
> --- a/lib.c
> +++ b/lib.c
> @@ -834,7 +834,7 @@ static void predefined_macros(void)
>         add_pre_buffer("#define __CHECKER__ 1\n");
>
>         val = (1ULL << (bits_in_long-1)) - 1;
> -       add_pre_buffer("#weak_define __LONG_MAX__ %#llxLL\n", val);
> +       add_pre_buffer("#weak_define __LONG_MAX__ %#llxL\n", val);
>         add_pre_buffer("#weak_define __SIZEOF_POINTER__ %d\n", bits_in_pointer/8);
>  }
>
> $
>
> Not a proper fix, but ...

Well, actually it is the proper fix as __LONG_MAX__ is supposed to be
a 'long' and not a 'long long'.

> Ah, I've just noticed you have sent some patches. ;-)
>
> I will take a look and let you know.

OK, thanks.
It should be OK as I new tested it on a 32bit machine but
another environment is always good for testing.

-- Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux