On Thu, Mar 23, 2017 at 10:00:17PM -0700, Christopher Li wrote: > On Mon, Mar 20, 2017 at 5:15 PM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> > > --- > > simplify.c | 20 +++++++++----------- > > 1 file changed, 9 insertions(+), 11 deletions(-) > > Looks good. It would be nice to have some test code to show the effect > of this change. There is no visible effect to show, in fact it would be an error if there any. Before the patch if some simplication was made, we returned directly to the CSE/simplification loop and canonicalization was done at some later cycles, once all simplifications had been made. But the goal of canonicalization is to limit the number of cases/patterns we need to check/handle during ... simplification. So canonicalization need to be done before the simplification. The fact that this patch also allow us to spare one cycle of CSE/simplification is just a nice side-effect. The real motivation was to prepare code for the following patch. Yes, I've been lazy in the message log, I'll update it. -- Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
