On Thu, Mar 02, 2017 at 06:41:35PM +0000, Dibyendu Majumdar wrote:
> This seems spot on as by making change as below, the final assertion
> failure went away. I have not yet checked the generated code but that
> is next.
>
> case OP_ADD:
> if (symbol_is_fp_type(C, insn->type))
> target = LLVMBuildFAdd(fn->builder, lhs, rhs, target_name);
> else {
> if (LLVMGetTypeKind(LLVMTypeOf(lhs)) == LLVMPointerTypeKind) {
> target = LLVMBuildGEP(fn->builder, lhs, &rhs, 1, "");
> }
> else if (LLVMGetTypeKind(LLVMTypeOf(lhs)) == LLVMPointerTypeKind) {
Yes, this is what I meant but here you're testing twice the type of 'lhs'.
One of the test should be on 'rhs'.
Can you resend it in another thread once it's fixed?
Thanks,
Luc
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
