On Tue, Feb 28, 2017 at 06:08:16PM +0000, Dibyendu Majumdar wrote: > > Following modified version should handle values than 0. Good, I'll cook a patch based on this. But I still have a fundamental problem with pseudo_to_value(). It's working with your example because we're using an OP_STORE and we're interesting in the type of the "target" and for this instruction (admittedly, like most instructions) insn->type is the type of insn->target. With insn->src or OP_SETNE, the result would have been incorrect. So while this patch is a little improvement and doesn't hurt, it's still not a good solution. What I last wrote on the subject the 29th Jan still holds (the "type" info should be given as argument to pseudo_to_value() instead of passing the pointer to the instruction) or at least something along this line. Luc Van Oostenryck -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
