Currently we simplify multiplication by 1 but nothing for the similar divide by 1. This patch add the missing simplification together with its test cases. Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx> --- simplify.c | 1 + validation/optim/muldiv-by-one.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/simplify.c b/simplify.c index b242b64d6..91021dbb1 100644 --- a/simplify.c +++ b/simplify.c @@ -348,6 +348,7 @@ static int simplify_constant_rightside(struct instruction *insn) case OP_ASR: return simplify_asr(insn, insn->src1, value); + case OP_DIVU: case OP_DIVS: case OP_MULU: case OP_MULS: return simplify_mul_div(insn, value); diff --git a/validation/optim/muldiv-by-one.c b/validation/optim/muldiv-by-one.c index ac8ac95b2..f6dd7cb2c 100644 --- a/validation/optim/muldiv-by-one.c +++ b/validation/optim/muldiv-by-one.c @@ -3,6 +3,8 @@ typedef int si; si smul1(si a) { return a * 1; } ui umul1(ui a) { return a * 1; } +si sdiv1(si a) { return a / 1; } +ui udiv1(ui a) { return a / 1; } /* * check-name: muldiv-by-one @@ -10,4 +12,5 @@ ui umul1(ui a) { return a * 1; } * check-output-ignore * * check-output-excludes: mul[us]\\. + * check-output-excludes: div[us]\\. */ -- 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html