On Tue, Feb 07, 2017 at 10:53:16AM +0800, Christopher Li wrote: > On Wed, Dec 7, 2016 at 11:46 PM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > Currently we simplify multiplication by 1 but nothing > > for the similar divide by 1. > > > > --- a/simplify.c > > +++ b/simplify.c > > @@ -320,6 +320,10 @@ static int simplify_mul_div(struct instruction *insn, long long value) > > case OP_MULU: > > if (value == 0) > > return replace_with_pseudo(insn, insn->src2); > > + /* Fall through */ > > + case OP_DIVS: > > + case OP_DIVU: > > + break; > > This patch has already applied to sparse-next. Just one minor comment that > if the fall through is just a break. It is better just break there. If > the later code > need to use the fall though, just add the fall through part with the later code. Mmmh yes. In fact here these 4 lines are not needed at all. It's most probably leftover of some code restructuration. Do you want that I send a new version of this patch? Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
