On Tue, Dec 06, 2016 at 02:00:50PM +0800, Christopher Li wrote: > 1) name of constexpr_flags is too long. > > struct expression { > enum expression_type type:8; > - unsigned flags:8; > + unsigned constexpr_flags:8; > > I actually thing that the more generic name "flags" are fine > without changing. If we need to add other flags not related to > constant, we will need to rename it all over again. I'd suggest to also add on th same line a comment like: // used for the kinds of constant expression - Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html