On Tue, Nov 22, 2016 at 06:02:04PM +0800, Christopher Li wrote: > On Mon, Nov 21, 2016 at 12:14 PM, Luc Van Oostenryck > <luc.vanoostenryck@xxxxxxxxx> wrote: > > These two patches solves the testing problem of the label names > > as emitted by test-linearize and others being not comparable > > between runs. > > I think it is much easier just let test-linearize print out label in > a predictable way. Absolutely. It's what I'm doing here on my working tree. > e.g. In the "struct basic_block", there is this > two fields "generation" and "priv". The "generation" is used by > flow analyze to store some state. Same as the "priv", which is > used by the back end to store some back end related state. > > Since test-linearize can treat as a back end, it is perfectly safe > to store some allocation number into the "priv". The problem with this 'priv' is that it's, well ... private, if we reuse it to store labels IDs it possibly can't be used anymore for this private usage. I would be more tempted to reuse the 'generation' field which is a long and don't need much bits. Of course, the real question is if that's such important to not add a new field to struct bb. > Than we don't need to complicate the test-suit script to do the > label normalization. Sure. But it should be noted that this filtering stuff *could* be useful for other things to (but I have no such uses). Luc -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
