No functional changes:
- factorize out the '->bb = NULL' and '|= REPEAT_CSE'.
- fall through the switch cases for ternary/bunary/unary ops.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@xxxxxxxxx>
---
simplify.c | 46 ++++++++++++++++++++--------------------------
1 file changed, 20 insertions(+), 26 deletions(-)
diff --git a/simplify.c b/simplify.c
index afbbb7b6..fc69def1 100644
--- a/simplify.c
+++ b/simplify.c
@@ -188,12 +188,14 @@ void kill_instruction(struct instruction *insn)
return;
switch (insn->opcode) {
+ case OP_SEL:
+ case OP_RANGE:
+ kill_use(&insn->src3);
+ /* fall through */
+
case OP_BINARY ... OP_BINCMP_END:
- insn->bb = NULL;
- kill_use(&insn->src1);
kill_use(&insn->src2);
- repeat_phase |= REPEAT_CSE;
- return;
+ /* fall through */
case OP_CAST:
case OP_SCAST:
@@ -201,42 +203,34 @@ void kill_instruction(struct instruction *insn)
case OP_PTRCAST:
case OP_SETVAL:
case OP_NOT: case OP_NEG:
- insn->bb = NULL;
kill_use(&insn->src1);
- repeat_phase |= REPEAT_CSE;
- return;
+ break;
case OP_PHI:
clear_phi(insn);
- insn->bb = NULL;
- repeat_phase |= REPEAT_CSE;
- return;
+ break;
case OP_SYMADDR:
- insn->bb = NULL;
- repeat_phase |= REPEAT_CSE | REPEAT_SYMBOL_CLEANUP;
- return;
+ repeat_phase |= REPEAT_SYMBOL_CLEANUP;
+ break;
- case OP_SEL:
- case OP_RANGE:
- insn->bb = NULL;
- repeat_phase |= REPEAT_CSE;
- kill_use(&insn->src1);
- kill_use(&insn->src2);
- kill_use(&insn->src3);
- return;
case OP_BR:
+ if (!insn->cond)
+ break;
+ /* fall through */
+
case OP_COMPUTEDGOTO:
- insn->bb = NULL;
- repeat_phase |= REPEAT_CSE;
- if (insn->cond)
- kill_use(&insn->cond);
- return;
+ kill_use(&insn->cond);
+ break;
case OP_ENTRY:
/* ignore */
return;
}
+
+ insn->bb = NULL;
+ repeat_phase |= REPEAT_CSE;
+ return;
}
/*
--
2.10.2
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
