Thanks for your reply.
I'll resubmit shortly.
Do you mean it as an error in the sparse tool?
I don't think so, I took a look and it seems to be designed to output
an error for that case.
On Sun, Nov 17, 2013 at 7:40 PM, Joe Perches <joe@xxxxxxxxxxx> wrote:
> On Sun, 2013-11-17 at 18:18 -0200, Erico Nunes wrote:
>> This patch fixes the following errors reported when running sparse:
>> fs/jffs2/super.c:378:1: error: directive in argument list
>> fs/jffs2/super.c:380:1: error: directive in argument list
>> fs/jffs2/super.c:381:1: error: directive in argument list
>> fs/jffs2/super.c:383:1: error: directive in argument list
>
> Seems like a sparse error more than anything else.
> (adding sparse mailing list)
>
> Also you need to add a "Signed-off-by:" line
> with your email address.
>
> see: Documentation/SubmittingPatches
>
>> ---
>> fs/jffs2/super.c | 17 +++++++++--------
>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/fs/jffs2/super.c b/fs/jffs2/super.c
>> index 0defb1c..ec9e16f 100644
>> --- a/fs/jffs2/super.c
>> +++ b/fs/jffs2/super.c
>> @@ -361,6 +361,14 @@ MODULE_ALIAS_FS("jffs2");
>> static int __init init_jffs2_fs(void)
>> {
>> int ret;
>> + const char desc[] = "version 2.2."
>> +#ifdef CONFIG_JFFS2_FS_WRITEBUFFER
>> + " (NAND)"
>> +#endif
>> +#ifdef CONFIG_JFFS2_SUMMARY
>> + " (SUMMARY) "
>> +#endif
>> + " © 2001-2006 Red Hat, Inc.";
>>
>> /* Paranoia checks for on-medium structures. If we ask GCC
>> to pack them with __attribute__((packed)) then it _also_
>> @@ -374,14 +382,7 @@ static int __init init_jffs2_fs(void)
>> BUILD_BUG_ON(sizeof(struct jffs2_raw_inode) != 68);
>> BUILD_BUG_ON(sizeof(struct jffs2_raw_summary) != 32);
>>
>> - pr_info("version 2.2."
>> -#ifdef CONFIG_JFFS2_FS_WRITEBUFFER
>> - " (NAND)"
>> -#endif
>> -#ifdef CONFIG_JFFS2_SUMMARY
>> - " (SUMMARY) "
>> -#endif
>> - " © 2001-2006 Red Hat, Inc.\n");
>> + pr_info("%s\n", desc);
>>
>> jffs2_inode_cachep = kmem_cache_create("jffs2_i",
>> sizeof(struct jffs2_inode_info),
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
