Re: [PATCH] sparse: add __builtin_va_arg_pack() and __builtin_va_arg_pack_len()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 18, 2013 at 8:36 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> this patch stops sparse from complaining about them not being defined:
>
>     /usr/include/bits/stdio2.h:98:25: error: undefined identifier '__builtin_va_arg_pack'
>     /usr/include/bits/stdio2.h:98:25: error: not a function <noident>
>
> Probably, there is some better way to do this that actually validates
> this function, but I'm not clear on how to do it.
>

Please add a test case for the typical usage case of __buildin_va_arg_pack()
and __builtin_va_arg_pack_len(). At the very least, it needs to cover the real
world breakage that bother you enough to submit a patch.

The patch looks good otherwise.

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux