On 10/07/2013 13:54, Dan Carpenter wrote:
---
Side note: Sparse should warn about endian bugs but in linux-next
endian checking is disabled because we hit:
include/uapi/linux/swab.h:71:16: error: undefined identifier '__builtin_bswap64'
include/uapi/linux/swab.h:71:33: error: not a function <noident>
do_error() in Sparse disables warning messages. I feel like we
shouldn't do that.
/* Shut up warnings after an error */
max_warnings = 0;
---
Hello Eli Cohen,
The patch e126ba97dba9: "mlx5: Add driver for Mellanox Connect-IB
adapters" from Jul 7, 2013, has an endian related bug:
drivers/net/ethernet/mellanox/mlx5/core/main.c
214 memset(&set_out, 0, sizeof(set_out));
215 set_ctx->hca_cap.uar_page_sz = cpu_to_be16(PAGE_SHIFT - 12);
^^^^^^^^^^^^^^^^^^^
This is defined in the header as be32 but we are saving a be16 to it.
My guess is the header is correct and the be16 is wrong.
216 set_ctx->hdr.opcode = cpu_to_be16(MLX5_CMD_OP_SET_HCA_CAP);
217 err = mlx5_cmd_exec(dev, set_ctx, sizeof(*set_ctx),
218 &set_out, sizeof(set_out));
regards,
dan carpenter
Dan, this sparse catch was reported earlier by Fengguang Wu
<fengguang.wu@xxxxxxxxx>, we have a fix, will send now
Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
