On Thu, May 16, 2013 at 11:55 PM, Xi Wang <xi.wang@xxxxxxxxx> wrote:
> The results of cast_to() seem unused. Assign them to expr->left and
> expr->right.
>
> Signed-off-by: Xi Wang <xi.wang@xxxxxxxxx>
How did you find about this? Is this needed to fix a reproducible issue?
> ---
> evaluate.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/evaluate.c b/evaluate.c
> index 0dfa519..d9c767f 100644
> --- a/evaluate.c
> +++ b/evaluate.c
> @@ -1024,11 +1024,11 @@ static struct symbol *evaluate_compare(struct expression *expr)
> goto OK;
> }
> if (is_null1 && (rclass & TYPE_PTR)) {
> - left = cast_to(left, rtype);
> + expr->left = cast_to(left, rtype);
> goto OK;
> }
> if (is_null2 && (lclass & TYPE_PTR)) {
> - right = cast_to(right, ltype);
> + expr->right = cast_to(right, ltype);
> goto OK;
> }
> }
> @@ -1044,11 +1044,11 @@ static struct symbol *evaluate_compare(struct expression *expr)
> if (expr->op == SPECIAL_EQUAL || expr->op == SPECIAL_NOTEQUAL) {
> if (ltype->ctype.as == rtype->ctype.as) {
> if (lbase == &void_ctype) {
> - right = cast_to(right, ltype);
> + expr->right = cast_to(right, ltype);
> goto OK;
> }
> if (rbase == &void_ctype) {
> - left = cast_to(left, rtype);
> + expr->left = cast_to(left, rtype);
> goto OK;
> }
> }
> --
> 1.8.1.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
