On Wed, 2013-03-06 at 13:45 -0800, Josh Triplett wrote: > On Wed, Mar 06, 2013 at 09:22:58AM -0800, Joe Perches wrote: > > --- a/Makefile > > +++ b/Makefile > > @@ -1,5 +1,12 @@ > > VERSION=0.4.4 > > > > +HAVE_GIT:=$(shell git describe >/dev/null 2>&1 && echo 'yes') > > +ifeq ($(HAVE_GIT),yes) > > +SPARSE_VERSION=$(shell git describe) > > +else > > +SPARSE_VERSION=$(VERSION) > > +endif > > + > > The "dist" target already has a call to "git describe"; could you unify > the two? (And, ideally, avoid calling git describe twice, once for > HAVE_GIT and once for SPARSE_VERSION?) I think the overhead is low and not worth the bother. Go for it if it bothers you. -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
