On Tue, Nov 13, 2012 at 04:13:41PM -0600, danielfsantos@xxxxxxx wrote: > Introduce compiletime_assert to compiler.h, which moves the details of > how to break a build and emit an error message for a specific compiler > to the headers where these details should be. Following the tradition of > the POSIX assert macro, compiletime_assert creates a build-time error > when the supplied condition is *false*. > > Next, we add BUILD_BUG_ON_MSG to bug.h which simply wraps > compiletime_assert, inverting the logic, so that it fails when the > condition is *true*, consistient with the language "build bug on." This > macro allows you to specify the error message you want emitted when the > supplied condition is true. > > Finally, we remove all other code from bug.h that mucks with these > details (BUILD_BUG & BUILD_BUG_ON), and have them all call > BUILD_BUG_ON_MSG. This not only reduces source code bloat, but also > prevents the possibility of code being changed for one macro and not for > the other (which was previously the case for BUILD_BUG and > BUILD_BUG_ON). > > Signed-off-by: Daniel Santos <daniel.santos@xxxxxxxxx> Looks nice and clean. Acked-by: Borislav Petkov <bp@xxxxxxxxx> -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
