On 10/24/2012 02:55 PM, Borislav Petkov wrote: > On Wed, Oct 24, 2012 at 11:33:55AM -0500, danielfsantos@xxxxxxx wrote: >> Currently, we are only including asm/bug.h and then expecting that >> linux/compiler.h will eventually be included to define __linktime_error >> (used in BUILD_BUG_ON). This patch includes it directly for clarity and >> to avoid the possibility of changes in <arch>/*/include/asm/bug.h being >> changed or not including linux/compiler.h for some reason. (Later >> patches will in this set use more macros defined in compiler*.h.) >> >> Signed-off-by: Daniel Santos <daniel.santos@xxxxxxxxx> >> --- >> include/linux/bug.h | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/bug.h b/include/linux/bug.h >> index aaac4bb..4bd74d8 100644 >> --- a/include/linux/bug.h >> +++ b/include/linux/bug.h >> @@ -2,6 +2,7 @@ >> #define _LINUX_BUG_H >> >> #include <asm/bug.h> >> +#include <linux/compiler.h> >> >> enum bug_trap_type { >> BUG_TRAP_TYPE_NONE = 0, >> -- >> 1.7.3.4 > Why is this a separate patch and why not add that single line in 6/10 > where you define BUILD_BUG_ON? > > Thanks. Sorry about that. I think this was originally in another patch with something else that I moved to another patch set and it ended up by its self. I'll squash it and resubmit. -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html