This is required for producing valid LLVM bitcode.
Cc: Pekka Enberg <penberg@xxxxxxxxxx>
Cc: Christopher Li <sparse@xxxxxxxxxxx>
Cc: Jeff Garzik <jgarzik@xxxxxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
---
sparse-llvm.c | 17 ++++++++++++++++-
validation/backend/loop2.c | 13 +++++++++++++
2 files changed, 29 insertions(+), 1 deletion(-)
create mode 100644 validation/backend/loop2.c
diff --git a/sparse-llvm.c b/sparse-llvm.c
index 0fc0dae..2048a1b 100644
--- a/sparse-llvm.c
+++ b/sparse-llvm.c
@@ -1111,16 +1111,31 @@ static void output_insn(struct function *fn, struct instruction *insn)
static void output_bb(struct function *fn, struct basic_block *bb, unsigned long generation)
{
struct instruction *insn;
+ struct instruction_list *remaining = NULL;
bb->generation = generation;
+ /*
+ * LLVM requires the phi instructions to be grouped at the top of each
+ * basic block.
+ */
+
FOR_EACH_PTR(bb->insns, insn) {
if (!insn->bb)
continue;
- output_insn(fn, insn);
+ if (insn->opcode == OP_PHI)
+ output_insn(fn, insn);
+ else
+ add_instruction(&remaining, insn);
}
END_FOR_EACH_PTR(insn);
+
+ FOR_EACH_PTR(remaining, insn) {
+ output_insn(fn, insn);
+ } END_FOR_EACH_PTR(insn);
+
+ free_ptr_list(&remaining);
}
#define MAX_ARGS 64
diff --git a/validation/backend/loop2.c b/validation/backend/loop2.c
new file mode 100644
index 0000000..4e44a15
--- /dev/null
+++ b/validation/backend/loop2.c
@@ -0,0 +1,13 @@
+extern int op(void);
+
+static void test(void) {
+ int i;
+ for (i = 0; ; i++) {
+ op();
+ }
+}
+
+/*
+ * check-name: Loops with unused counter
+ * check-command: ./sparsec -c $file -o tmp.o
+ */
--
1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
