On Fri, Oct 05, 2012 at 02:42:42PM -0500, danielfsantos@xxxxxxx wrote: > Using GCC_VERSION reduces complexity, is easier to read and is GCC's > recommended mechanism for doing version checks. (Just don't ask me why > they didn't define it in the first place.) This also makes it easy to > merge compiler-gcc{,3,4}.h should somebody want to. > > Signed-off-by: Daniel Santos <daniel.santos@xxxxxxxxx> > Acked-by: David Rientjes <rientjes@xxxxxxxxxx> > --- [ … ] > diff --git a/include/linux/compiler-gcc4.h b/include/linux/compiler-gcc4.h > index 4506d65..bbfeb13 100644 > --- a/include/linux/compiler-gcc4.h > +++ b/include/linux/compiler-gcc4.h > @@ -4,7 +4,7 @@ > > /* GCC 4.1.[01] miscompiles __weak */ > #ifdef __KERNEL__ > -# if __GNUC_MINOR__ == 1 && __GNUC_PATCHLEVEL__ <= 1 > +# if GCC_VERSION >= 40100 && GCC_VERSION <= 40101 > //# error Your version of gcc miscompiles the __weak directive Did I miss something again? This "error" preprocessor function is commented out here? Why? -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html