On Tue, Oct 02, 2012 at 11:49:03PM -0700, David Rientjes wrote: > On Fri, 28 Sep 2012, Josh Triplett wrote: > > > That issue doesn't relate to __flatten, though; it only relates to > > __weak. Since __flatten (and __compiletime_object_size) will work fine > > on 4.1.0 and 4.1.1, don't exclude them just because the definition for > > __weak elsewhere in the file excludes them. That just makes it harder > > for anyone who might want to work on the issue with __weak. > > > > Nack to the patch since there are no users of it; there's no need to > define every possible gcc function attribute. If anything actually needs > to use __attribute__((flatten)), then it can introduce it. This patch series started out as part of another patch series by Daniel Santos that makes use of __flatten; I think Daniel plans to have that patch series depend on this one. Thus, I think it makes sense to introduce __flatten at this point. - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html