Re: [PATCH 2/2] ptrlist.c: fix a typo in a comment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/01/2012 11:59 PM, Mauro Dreissig wrote:
> On 06/18/2012 06:39 PM, Jonathan Neuschäfer wrote:
>> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@xxxxxxx>
>> ---
>>  ptrlist.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ptrlist.c b/ptrlist.c
>> index 2620412..5dc1117 100644
>> --- a/ptrlist.c
>> +++ b/ptrlist.c
>> @@ -35,7 +35,7 @@ int ptr_list_size(struct ptr_list *head)
>>   *
>>   * The array to linearize into (second argument) should really
>>   * be "void *x[]", but we want to let people fill in any kind
>> - * of pointer array, so let's just call it "void *".
>> + * of pointer array, so let's just call it "void **".
>>   */
>>  int linearize_ptr_list(struct ptr_list *head, void **arr, int max)
>>  {
>>
> 
> Hi!
> 
> It looks like the comment was left there by mistake. I belive the idea
> was to call the second argument void * to avoid warnings when passing
> other_type ** to the function without having to cast it to void **.
> 
> Reading the comment now only gives the idea that declaring the argument
> as void ** instead of void *[] gives different semantics, which is not the case. 
> 
> Mauro
> 

Ah, I think I get it.. You cant cast something to "void *[]". sry :P
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux