Re: [PATCH] cse: update PHI users when throwing away an instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/28/2011 02:33 AM, Pekka Enberg wrote:
On Sat, Aug 27, 2011 at 4:39 PM, Kamil Dudka<kdudka@xxxxxxxxxx>  wrote:
The attached patch solves the dangling PHI nodes and does not seem to break
anything at first glance.  It is probably not the most efficient solution,
but it might at least show where to look for the problem.

On Sun, Aug 28, 2011 at 3:34 AM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx>  wrote:
Hmm. From a quick look, looks fine to me. And checks the kernel, and
does indeed get rid of the extraneous phi nodes in the test-case.

Ack.

I applied both patches to sparse-llvm.git. Jeff, do they cure all loop
related issues?

They look promising... Currently loops are stuck due to issues unrelated to core sparse: OP_PHI does not show successor phi's due to ->priv==NULL. Loops definitely will not work without both predecessors and successors both having a correct ->priv pointing to LLVM data.

	Jeff




--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux