Hi, I've started working on a new check for sparse to pick up a common error -- identical expressions appearing on both sides of some binary operators. This initially supports '&&', and incompletely -- but the plan is to check instances of '!=', '==' and '||' the same way. The check relies on recursively walking the ->left and ->right expressions, looking for differences. The implementation is a little verbose, but can be shared between all the operators. What I'd like to know is: * Do people consider this a worthwhile check to make? * Am I "doing it right" with the expression walking? * Are there other cases which people would be interested in? Cheers -- Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
