On 04/11/2011 12:20 AM, Christopher Li wrote: > Hi Jan, > > You are one fire with this sparse code :-) > > I will take a closer look of your patch series tonight. > > Thanks > > Chris > > > On Sun, Apr 10, 2011 at 9:24 AM, Jan Pokorný <pokorny_jan@xxxxxxxxx> wrote: >> Also remove unneeded empty initializator of `void_pseudo'. >> >> Signed-off-by: Jan Pokorny <pokorny_jan@xxxxxxxxx> >> --- >> linearize.c | 4 ++-- >> 1 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/linearize.c b/linearize.c >> index f2034ce..46c9726 100644 >> --- a/linearize.c >> +++ b/linearize.c >> @@ -33,7 +33,7 @@ struct access_data; >> static pseudo_t add_load(struct entrypoint *ep, struct access_data *); >> static pseudo_t linearize_initializer(struct entrypoint *ep, struct expression *initializer, struct access_data *); >> >> -struct pseudo void_pseudo = {}; >> +struct pseudo void_pseudo; >> >> static struct position current_pos; >> >> @@ -1880,7 +1880,7 @@ pseudo_t linearize_statement(struct entrypoint *ep, struct statement *stmt) >> struct basic_block *active; >> pseudo_t src = linearize_expression(ep, expr); >> active = ep->active; >> - if (active && src != &void_pseudo) { >> + if (active && src != VOID) { >> struct instruction *phi_node = first_instruction(bb_return->insns); >> pseudo_t phi; >> if (!phi_node) { >> -- >> 1.7.1 >> -- Hi Chris, thank you for considering these patches, feel free to bother me with complains :-) I think I will have some more patches to send, but it should not be tightly related to what I have already posted (if so, I'll make it explicit). -- Jan -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html