On Tue, Nov 23, 2010 at 6:10 AM, Christopher Li <sparse@xxxxxxxxxxx> wrote: > On Sun, Nov 21, 2010 at 12:25 PM, Nicolas Kaiser <nikai@xxxxxxxxx> wrote: >> I noticed that the second part of this conditional is always true. >> Just a shot in the dark: Could that be a typo? >> - if (insn->bb && (insn->opcode != OP_LOAD || insn->opcode != OP_STORE)) >> + if (insn->bb && (insn->opcode != OP_LOAD && insn->opcode != OP_STORE)) > > I think you are right. The insn->opcode can't be both OP_LOAD and OP_STORE. > > The fix seems right to me. That is a good catch. I wonder if running sparse on it could catch this... Regards, -- Anderson Lizardo -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html