On Wednesday, October 06, 2010 03:10:19 Josh Triplett wrote: > On Wed, Oct 06, 2010 at 01:38:02AM -0400, Mike Frysinger wrote: > > On Tuesday, October 05, 2010 22:33:21 Christopher Li wrote: > > > Can we have some "ifdef" for the blackfin architecture in the pre > > > buffer? I agree with Josh, that do look like very much blackfin > > > specific. We can leave the ignore attribute alone for now. > > > > how would #ifdefs help ? i'm not building sparse for a Blackfin arch, > > host or target wise. if there's something more, you'd have to be > > specific as to what you mean, otherwise i wont be able to send an > > updated patch. > > I suspect that Chris meant that you could add_pre_buffer an #ifdef and > #endif surrounding the #define, so that the #define would only take > effect if Sparse (or the command-line options passed by cgcc or Linux) > defined some appropriate architecture-specific symbol for Blackfin. i guess sparse doesnt automatically propogate defines that gcc uses, so i'd have to add "-D__bfin__" to CHECKFLAGS in arch/blackfin/Makefile. but that is what people are expecting, right ? -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
