On 06/10/2010 09:18 PM, Christopher Li wrote: > Hi Jirl, Hi, (the last letter in my name should be small I :)) > Can you add a validations test case for me? It would be great to see > sparse fail on the test case then your patch makes it work. static inline int __static_cpu_has(unsigned char bit) { asm goto("1: jmp %l[t_no]\n" "2:\n" ".section .altinstructions,\"a\"\n" "\n" "1b\n" "0\n" /* no replacement */ " .byte %P0\n" /* feature bit */ " .byte 2b - 1b\n" /* source len */ " .byte 0\n" /* replacement len */ " .byte 0xff + 0 - (2b-1b)\n" /* padding */ ".previous\n" : : "i" (bit) : : t_no, ble); return 1; t_no: return 0; } > Some minor nitpick follows. If you are busy, just give me the test case, > I can do the rest of the change for you, If you could do it, I would appreciate that. thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html