On Tue, Oct 27, 2009 at 5:46 PM, Dan McGee <dan@xxxxxxxxxxxxx> wrote: > `install` by default uses 755 permissions; for everything but executables we > want to use 644 permissions. So far so good. > -define INSTALL_CMD > +define INSTALL_PROG I rename it to INSTALL_EXEC and INSTALL_FILE respectively. > $(Q)$(QUIET_INST_SH)install -v $1 $(DESTDIR)$2/$1 || exit 1; > +endef Your patch remove a newline which is critical here. It is very subtle when using it inside a $(foreach ) loop. $(foreach ) blindly concatenate loop both. '@' only have special meaning after a newline. I get "@echo" command not found without this new line. The others look good. I apply a version with the rename and newline changes in chrisl branch. Let me know that works for you or not. If you have other feed back of the change, I can still change it. Thanks Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
