On Sun, Aug 16, 2009 at 10:03:53AM +0300, Pekka Enberg wrote: > On Sat, 2009-08-15 at 15:36 -0700, Josh Triplett wrote: > > These defines need to have the right type suffixes. GCC defines > > __LONG_LONG_MAX__ with an LL suffix, and __LONG_MAX__ with an L suffix. > > You could either add the appropriate suffixes, or better yet, stringize > > the constants and print them as strings. > > Right. Is there a macro in sparse to do the stringification? I didn't > find one and the best I could come up is this. [...] > --- a/lib.c > +++ b/lib.c > @@ -788,6 +788,14 @@ void create_builtin_stream(void) > add_pre_buffer("#define __OPTIMIZE__ 1\n"); > if (optimize_size) > add_pre_buffer("#define __OPTIMIZE_SIZE__ 1\n"); > + > + /* GCC defines these for limits.h */ > + add_pre_buffer("#weak_define __SHRT_MAX__ " STRINGIFY(__SHRT_MAX__) "\n"); > + add_pre_buffer("#weak_define __SCHAR_MAX__ " STRINGIFY(__SCHAR_MAX__) "\n"); > + add_pre_buffer("#weak_define __INT_MAX__ " STRINGIFY(__INT_MAX__) "\n"); > + add_pre_buffer("#weak_define __LONG_MAX__ " STRINGIFY(__LONG_MAX__) "\n"); > + add_pre_buffer("#weak_define __LONG_LONG_MAX__ " STRINGIFY(__LONG_LONG_MAX__) "\n"); > + add_pre_buffer("#weak_define __WCHAR_MAX__ " STRINGIFY(__WCHAR_MAX__) "\n"); > } > > static struct symbol_list *sparse_tokenstream(struct token *token) > diff --git a/lib.h b/lib.h > index b22fa93..62f7433 100644 > --- a/lib.h > +++ b/lib.h > @@ -17,6 +17,9 @@ > #include "compat.h" > #include "ptrlist.h" > > +#define __STRINGIFY(x) #x > +#define STRINGIFY(x) __STRINGIFY(x) > + This looks fine, with one minor nit: s/__STRINGIFY/STRINGIFY2/g or similar. The C language reserves identifiers containing "__" (C99 "7.1.3 Reserved identifiers"). - Josh Triplett -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html