On Thu, Aug 6, 2009 at 19:27, Kamil Dudka<kdudka@xxxxxxxxxx> wrote: > On Thursday 06 of August 2009 19:10:30 Christopher Li wrote: >> I would just apply the change to the header file and related variables. >> The linearize.h is consider an API header file for other sparse application >> to use. So we'd better not assume too much on the sparse caller side. >> >> I agree with Kamil that rename variable in linearize.c offer no real >> benefits. I consider it more of a personal preference thing. And it is >> internal to linearize.c. At this point renaming variable will mess up with >> annotations. It is not good enough reason to do it just to make >> the editor happy. > > Well, let's make a tradeoff - we can only change the identifiers > in linearize.h and the corresponding identifiers in linearize.c. I admit it > could be confusing when we have different identifiers in the prototype and > different identifiers in the function body. New version of the patch is > attached. LGTM Acked-by: Hannes Eder <hannes@xxxxxxxxxxxxxx> Best, -Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
