On Mon, Jul 27, 2009 at 11:13 AM, Hannes Eder<hannes@xxxxxxxxxxxxxx> wrote: > Instrument validate/preprocessor/preproprocessor*.c to be integrated > into the test-suite where missing and add an additional test case. Thanks, applied. > Ok there is a difference in the number of empty lines, who cares, but > spares outputs a "," and cpp does not. > > Could somebody with more insight comment on this? Al? :) > > Meanwhile I marked this test as "check-known-to-fail". Currently sparse did not handle ##__VA_ARGS__ the same ways as gcc. Take a look at parse_expansion(). It marks TOKEN_GNU_KLUDGE only if it saw "," right before "##__VA_ARGS__". So ",##x##__VA_ARGS__" will not get generate TOKEN_GNU_KLUDE. The fix is that ##__VA_ARGS__ should kick in *after* the argument list has been expanded. It literally delete the previous "," if __VA_ARGS__ is empty. Am I missing any thing, AI? Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html