Christopher Li wrote: > On Tue, Jul 21, 2009 at 2:50 PM, Ramsay Jones<ramsay@xxxxxxxxxxxxxxxxxxx> wrote: >> Hmm, I noticed that you edited the "subject line" when you applied >> the patch; namely s/shell/pkg-config/. >> >> I find this a little puzzling, since the error message *is* issued >> by the shell and is definitely *not* issued by pkg-config... which >> is kinda the point... ;-) >> > Oh, right. The error is issue from shell when it try to run pkg-config. > If I just read the title, it is hard for me to predict where the change > is going to be. I just want to be more specific. > > There is a reason I haven't push those to official tree yet. We can > still change it if we want. Suggestion? I liked the original myself. :) The "Makefile:" prefix was intended to indicate where the change was made and I thought that the one-line summary was compact and accurate. It's a bit difficult to indicate that "the cause of the error, which is issued by the shell, is a missing pkg-config command on some systems" as part of the one-line summary. (So I didn't try ;P ) Having said that, I can't claim to be good at writing commit messages. So, feel free to re-write it as you wish. ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
