Re: [PATCH 5/5] Add a --version option to sparse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 18, 2009 at 2:06 PM, Ramsay Jones<ramsay@xxxxxxxxxxxxxxxxxxx> wrote:
>
> In addition to a minimal --version implementation, using
> the output of 'git describe', we also output the version
> string when -v(erbose) output has been requested.
>
> Also, when cgcc internally sets the $gcc_base_dir, the
> compiler invocation is changed to use an explicit gcc
> command, rather than $cc. (when --version is part of
> $cc, this breaks badly).
>
> Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx>

Sorry I did not have a chance to reply it earlier. I was on a trip, very limited
Internet access.

> ---
>
> Hi Chris,
>
> This patch actually adds a feature :-)
>
> This is a minimal implementation and doesn't address the issue
> of a sparse library version number; should the library define
> some version macros like __SPARSE_MAJOR, __SPARSE_MINOR, etc.?
> Dunno.

I don't mind sparse has a version number. Some thing like 4.2.0 etc.
I would rather not mix that version number with the git commit hash.
The git commit hash has very limited usage. I think just print it as
part of the generic verbose printing is good enough. Add the printing in
handle_switch_v_finalize() so other executable can get it as well.

Thanks

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux