On Thu, Jul 9, 2009 at 08:29, Josh Triplett<josh@xxxxxxxxxxxxxxxx> wrote: > [Adding Linus and Chris Li to CC; Linus for further background on > -Wdo-while, and Chris Li for Sparse.] > > On Wed, Jul 08, 2009 at 09:28:24PM +0200, Vegard Nossum wrote: >> 2009/7/6 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: >> > Whether or not the sparse warning >> > >> > warning: do-while statement is not a compound statement >> > >> > is justified or not in this case, it is annoying and >> > trivial to fix. > [...] >> >> I'll change the patch title to "kmemcheck: work around bogus sparse >> warning" and fix the indentation, sounds ok? >> >> Meanwhile, I Cced sparse mailing list in case somebody else knows >> anything else about this warning (what it means, whether it's >> justified in this case, whether it should be fixed in sparse, etc.). > > -Wdo-while gives a warning if you write: > > do > statement > while (...); > > where "statement" does not consist of a compound statement surrounded by > braces. As far as I know, this warning exists primarily because it > matched Linus's preference for readability. see: http://lkml.org/lkml/2008/12/23/180 an related messages/threads Cheers, -Hannes -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
