On Wed, Jul 8, 2009 at 12:39 PM, Johannes Berg<johannes@xxxxxxxxxxxxxxxx> wrote: > Everybody take me off the CC please then :) This has been discussed far > too many times already. In this special case, the warning probably isn't > all that useful, but ISTR Linus saying that he wanted it this way. Right. I would keep the warning in sparse. I think it is better with the compound statement. It is easier to read which block is which. > - do if (ptr) { \ > + do { if (ptr) { \ BTW, if does not hurt to put the "if (ptr)" to a separate line. Chris -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html