Re: [PATCH v2] sparse: add LLVM code generation backend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christopher Li wrote:
On Sun, Apr 26, 2009 at 1:58 PM, Jeff Garzik <jeff@xxxxxxxxxx> wrote:
+       case EXPR_DEREF:
+       case EXPR_SIZEOF:
+       case EXPR_ALIGNOF:
+               warning(expr->pos, "invalid expression after evaluation");
+               return NULL;

Regarding using liniearize instruction vs rolling your own.

I don't think you can get more information than linearize instruction
here. EXPR_DEREF has already been processed during evaluation.

Recall the history of the code: show-parse.c -> compile-i386.c -> s2l-gen.c.

You can see the above code was taken verbatim from show-parse.c, and is probably nothing more than a check the original author (Linus?) felt appropriate at the time, for show-parse.c. I wouldn't read too much into its presence in s2l-gen.c -- maybe those checks can simply be deleted.

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux