[PATCH 9/18] Fix handling of typedefs with several declarators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We set MOD_USERTYPE only on the first one, so declaration_specifiers
didn't recognize something like
	unsigned P;
where P had been such a typedef as redefinition (see the testcase).

Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
---
 parse.c                    |    3 +++
 validation/multi_typedef.c |   15 +++++++++++++++
 2 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 validation/multi_typedef.c

diff --git a/parse.c b/parse.c
index 7b1cfb6..1435fde 100644
--- a/parse.c
+++ b/parse.c
@@ -2365,6 +2365,9 @@ struct token *external_declaration(struct token *token, struct symbol_list **lis
 			return token;
 		}
 
+		if (is_typedef)
+			decl->ctype.modifiers |= MOD_USERTYPE;
+
 		bind_symbol(decl, ident, is_typedef ? NS_TYPEDEF: NS_SYMBOL);
 
 		/* Function declarations are automatically extern unless specifically static */
diff --git a/validation/multi_typedef.c b/validation/multi_typedef.c
new file mode 100644
index 0000000..d9ffd0f
--- /dev/null
+++ b/validation/multi_typedef.c
@@ -0,0 +1,15 @@
+typedef int T, *P;
+static void f(void)
+{
+	unsigned P = 0;
+	unsigned x = P;
+}
+static void g(void)
+{
+	int P = 0;
+	int x = P;
+}
+/*
+ * check-name: typedefs with many declarators
+ * check-description: we didn't recognize P above as a typedef
+ */
-- 
1.5.6.5


--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux