On Thu, Jan 8, 2009 at 11:18 AM, Hannes Eder <hannes@xxxxxxxxxxxxxx> wrote:
> +
> + if (!strncmp(arg, "tabstop=", 8)) {
> + char *end;
> + unsigned long val;
> + arg += 8;
> +
> + if (*arg == '\0')
> + die("error: missing argument to \"-ftabstop=\"");
> +
> + /* we silently ignore silly values */
> + val = strtoul(arg, &end, 10);
> + if (*end == '\0' && 1 <= val && val <= 100)
> + tabstop = val;
> +
> + return next;
> + }
> +
> + /* handle switches w/ arguments above, boolean and only boolean below */
> +
> if (!strncmp(arg, "no-", 3)) {
> flag = 0;
> arg += 3;
Is that the only portion that get changed between v2 and v3?
It took me a while to realized what really get changed here.
I suggest a new function: handle_switch_ftabstop() here.
Then we do:
if (!strncmp(arg, "tabstop=", 8))
return handle_switch_ftabstop(arg+8, next);
It will make handle_switch_f cleaner.
I already apply your V2 patch. Can you make this change
an incremental patch against my tree?
Thanks
Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
