On 4/25/08, Pavel Roskin <proski@xxxxxxx> wrote: > Quoting Marko Kreen <markokr@xxxxxxxxx>: > > On 4/25/08, Pavel Roskin <proski@xxxxxxx> wrote: > > > Quoting Marko Kreen <markokr@xxxxxxxxx>: > > > > Patch attached. > > > > > > NACK. $m64 is only set if "-m64" was explicitly passed to cgcc. > > > > > > It looks like cgcc code expect sparse to handle it, and sparse expects > it > > > from cgcc. > > > > Do you mean the variables are not set? But they are: > > > > my $m32 = 0; > > my $m64 = 0; > > I mean, they are both 0 unless -m32 or -m64 is specified. No, see other sections - they assume one of them is set unless overrided. > > Or do you mean I cannot assume one of them as set, unless > > overrided on command line? But other sections (spact, i86, ppc) > > do exactly that? > > You cannot assume either of them to be 1 until cgcc is fixed. But how should the fix look like if you don't like mine? > > Or do you mean I cannot give extra -mXX arguement unless given by user? > > No, I don't mean it. It should be fine to add the -mXX argument. -- marko -- To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html