On 8/6/07, Josh Triplett <josh@xxxxxxxxxxxxxxx> wrote:
>
> Looks like some enums grew new values and ctags didn't stay up to date. I
> think this patch fixes that particular problem:
>
> diff --git a/ctags.c b/ctags.c
> index f5b8fc7..63f59a5 100644
> --- a/ctags.c
> +++ b/ctags.c
> @@ -111,6 +111,8 @@ static void examine_symbol(struct symbol *sym)
> return;
> if (sym->ident && sym->ident->reserved)
> return;
> + if (sym->type == SYM_KEYWORD)
> + return;
>
> add_tag(sym);
> base = sym->ctype.base_type;
> @@ -158,6 +160,8 @@ static void examine_namespace(struct symbol *sym)
> return;
>
> switch(sym->namespace) {
> + case NS_KEYWORD:
> + return;
> case NS_LABEL:
> sym->kind = 'l';
> break;
>
That looks good to me.
> After some further investigation, I think ctags really shouldn't look at
> SYM_PREPROCESSOR or NS_PREPROCESSOR either. I came up with the attached
> patch, which I will apply soon unless someone shouts. Chris?
I think SYM_PREPROCESSOR is also used by macros with NS_MACRO.
You just need to strip out the NS_PREPROCESSOR. I guess you try to
skip the symbol with NS_SYMBOL: and SYM_PREPROCESSOR at the same
time.
I am not sure about the test for "sym->type == SYM_KEYWORD",
do you see some case trigger that?
Sorry, I just find out that I get drop out from the sparse mail list
for a while and miss
a lot of interesting discussions. Blame my mail server.
>
> This still doesn't fix running ctags on multiple files; ctags seems to get
> confused in much the same way sparse does when run on multiple files: it spews
> a pile of redefinition errors.
Should make sparse able to clean up itself. I will see what I can do.
Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-sparse" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
