On Wed, Jun 27, 2007 at 09:10:21PM +0900, Neil Booth wrote: > Al Viro wrote:- > > > Hopefully correct handling of integer constant expressions. Please, review. > > Here are three independently invalid non-ICEs that sparse doesn't > diagnose. > > extern int f(void); > enum { cast_to_ptr = (int) (void *) 0 }; > enum { cast_to_float = (int) (double) 1 }; > enum { fncall = 0 ? f(): 3 }; > > Hey, I did warn you it was tricky :) Nope. They are recognized as non-ICE (try with struct { int n :<expr>;}; for tester). Again, no check for ICE in enums, and that one is for a good reason - we might very well want non-integer enums as an extension at some point. We certainly need to check that they are constant, though. If you want to test ICE recognition, right now only the following places are checking for it: * bitfield width * __attribute__((aligned(<number>))) * __attribute__((address_space(<number>))) * [<index>] in designators within initializer list * [<index> ... <index>] - ditto, gccism That's it. We can use it elsewhere too, but that's a separate bunch of patches (trivial to do now). - To unsubscribe from this list: send the line "unsubscribe linux-sparse" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html