Re: [PATCH 3] Fix core dump on huge switch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Christopher Li wrote:
> Bump up the size of the instruction buffer. vt_ioctl.c has
> a huge switch statement causing sparse over flow the instruction
> buffer.
> 
> Signed-Off-By: Christopher Li <sparse@xxxxxxxxxxx>

I've applied this fix for now, to solve the immediate problem; thanks for the patch.  

Ideally I'd like to see some solution that grows the buffer as needed.

I also committed one minor style fix after your patch:

> +	if (buf >= buffer + sizeof buffer)

Please use parentheses with sizeof, per the Linux Documentation/CodingStyle.

- Josh Triplett

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Newbies FAQ]     [LKML]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Trinity Fuzzer Tool]

  Powered by Linux