Christopher Li wrote:
> Fix a bug that match_idents forget to end with NULL
[...]
> Signed-Off-By: Christopher Li <sparse@xxxxxxxxxxx>
[...]
> - if (match_idents(token, &asm_ident, &__asm_ident, &__asm___ident)) {
> + if (match_idents(token, &asm_ident, &__asm_ident, &__asm___ident, NULL)) {
Applied.
I'd also like to apply a patch to use __attribute__((__sentinel__)) on
match_idents, which would have caught this problem. In order to do so
portably, I plan to add a portability macro SENTINEL_ATTR, like the
FORMAT_ATTR macro currently in lib.h. However, lib.h currently defines
FORMAT_ATTR, uses it for a few prototypes, and then undefines it. Any
objections to defining SENTINEL_ATTR and leaving it defined (and probably
doing the same for FORMAT_ATTR)? I don't think those would pollute the
namespace any more than lib.h already does with position, verbose, info, and
similar.
- Josh Triplett
Attachment:
signature.asc
Description: OpenPGP digital signature
